Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>

To: Tatsuo Ishii <ishii@postgresql.org>

Cc: li.evan.chao@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, pramsey@cleverelephant.ca, ojford@gmail.com, peter@eisentraut.org, krasiyan@gmail.com, vik@postgresfriends.org, andrew@tao11.riddles.org.uk, david@fetter.org

Date: 2025-10-22T04:18:31Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix coding style with "else".
- 20628b62e46e 19 (unreleased) landed
Fix multi WinGetFuncArgInFrame/Partition calls with IGNORE NULLS.
- 2d7b247cb414 19 (unreleased) landed
Fix Coverity issue reported in commit 2273fa32bce.
- dd766a441d69 19 (unreleased) landed
Use ereport rather than elog in WinCheckAndInitializeNullTreatment.
- 5f3808646f67 19 (unreleased) landed
Avoid uninitialized-variable warnings from older compilers.
- 71540dcdcb22 19 (unreleased) cited
Fix Coverity issues reported in commit 25a30bbd423.
- 2273fa32bce7 19 (unreleased) landed
Improve EXPLAIN's display of window functions.
- 8b1b342544b6 18.0 cited
Automatically generate node support functions
- 964d01ae90c3 16.0 cited

On Mon, 20 Oct 2025 at 16:59, Tatsuo Ishii <ishii@postgresql.org> wrote:
>
> > A very trivial commit:
> >
> > ```
> > +     else
> > +
> > +             /*
> > +              * For other cases we have no idea what position of row callers would
> > +              * fetch next time. Also for relpos < 0 case (we go backward), we
> > +              * cannot set mark either. For those cases we always set mark at 0.
> > +              */
> > +             mark_pos = 0;
> > ```
> >
> > The empty line after “else” is not needed.
>
> That was added by pgindent.

If it's written down somewhere, I can't find it, but the rule we
normally follow here is; don't use braces if the code block has a
single statement without any comments that appear on a separate line.
Otherwise, use braces.

Since your comments are not on the same line as the statement, it
should have braces. I imagine that's why pgindent is "acting weird".

David