Re: VACUUM (PARALLEL) option processing not using DefElem the way it was intended
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-08T22:08:36Z
Lists: pgsql-hackers
Attachments
- adjust_vacuum_parallel_option_handling_code_v2.patch (application/octet-stream) patch v2
On Thu, 9 Oct 2025 at 05:57, Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Oct-08, Masahiko Sawada wrote:
> > ereport(ERROR,
> > (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> > errmsg("BUFFER_USAGE_LIMIT option must be 0 or between %d kB
> > and %d kB",
> > MIN_BAS_VAC_RING_SIZE_KB, MAX_BAS_VAC_RING_SIZE_KB),
> > hintmsg ? errhint("%s", _(hintmsg)) : 0));
> >
> > Should we also change this for consistency with how we handle other
> > VACUUM options?
>
> I would appreciate that, and also a change there from errhint() to
> errhint_internal.
Ok, I've adjusted that in the attached.
David
Commits
-
Cleanup VACUUM option processing error messages
- 1b073cba4993 19 (unreleased) landed