Horton

Re: [PATCH] Add min/max aggregate functions to BYTEA

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Marat Bukharov <marat.buharov@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers@postgresql.org
Date: 2024-09-23T01:05:37Z
Lists: pgsql-hackers 
On Thu, 25 Jul 2024 at 02:42, Marat Bukharov <marat.buharov@gmail.com> wrote:
> V5 patch. I've added more tests with different bytea sizes

I just glanced over this patch. Are you still planning on working on
it? There's been no adjustments made since the last feedback you got
in early August.

Can you address Andrey's feedback on point #1?

Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
been done in record_larger() and record_smaller() except use
byteacmp(). That'll remove all the duplicated code.

If you fix those up, I see no reason not to commit the patch.

David

Commits

  1. Add min and max aggregates for bytea type.