Re: Typo in README.barrier
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-17T00:19:41Z
Lists: pgsql-hackers
Attachments
- README.barrier_v3.patch (application/octet-stream) patch v3
On Mon, 17 May 2021 at 01:29, Tatsuo Ishii <ishii@sraoss.co.jp> wrote: > Yes, we'd better to fix them. Attached is a propsal for these. Thanks for working on that. I had a look and wondered if it might be better to go into slightly less details about the exact atomic function to use. The wording there might lead you to believe you can just call the atomic function on the non-atomic variable. It might be best just to leave the details about how exactly to use atomics by just referencing port/atomics.h. Maybe something like the attached? I'm also a bit on the fence if this should be backpatched or not. The reasons though maybe not is that it seems unlikely maybe people would not be working in master if they're developing something new. On the other side of the argument, 0ccebe779, which adjusts another README was backpatched. I'm leaning towards backpatching. David
Commits
-
Fix typo and outdated information in README.barrier
- 943bda157eca 9.6.23 landed
- e71219ca11fa 10.18 landed
- a399755ba2fc 11.13 landed
- 898c62951e80 12.8 landed
- 010429eb1f77 13.4 landed
- 2ded19fa3a4d 14.0 landed