Re: Executor code - found an instance of a WHILE that should just be an IF
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-05-10T11:49:43Z
Lists: pgsql-hackers
On Mon, 10 May 2021 at 21:16, Greg Nancarrow <gregn4422@gmail.com> wrote: > During debugging I noticed some code in ExecResult() where a WHILE > loop is being used with an unconditional RETURN at the end of the > block (which is intentional, looking at the history of changes), but > now there's no actual use of the loop in any way. The code should > probably be changed to just use IF for clarity. > I've attached a patch. Looks like leftovers from ea15e1867. I don't think this will affect any code generation but you are right, it should be an "if". David
Commits
-
Convert misleading while loop into an if condition
- 6cb93beddd33 14.0 landed