Horton

Re: Refactor StringInfo usage in subscriptioncmds.c

David Rowley <dgrowleyml@gmail.com>

View thread
From: David Rowley <dgrowleyml@gmail.com>
To: Mats Kindahl <mats.kindahl@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, pgsql-hackers@lists.postgresql.org
Date: 2025-11-06T20:50:59Z
Lists: pgsql-hackers 
On Fri, 7 Nov 2025 at 01:47, Mats Kindahl <mats.kindahl@gmail.com> wrote:
> > I agree with Amit that there doesn't seem to be a need to free
> > pubnames.data.  We're already leaking publist, for instance.  This is
> > okay since we only call these functions during DDL, which in general is
> > not sensitive to leaks.
>
> Seems reasonable. Here is an updated version that removes the pfree() calls.

Sounds like all are in favour. Pushed.

David