Horton

Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-15T06:11:34Z
Lists: pgsql-hackers 
On Fri, 15 Aug 2025 at 17:25, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Aug 15, 2025 at 04:48:10PM +1200, David Rowley wrote:
> > Yes, I'm about to push the HASH_STATISTICS one and backpatch to v17.
>
> Thanks.

Done

> > I think we should fix and backpatch the HASH_DEBUG one. We can have a
> > separate debate on removing it in master only. It's hard to imagine
> > anyone objecting to fixing it, so let's just do that for the time
> > being.
>
> Sounds good to me.

Also done. (I didn't use the proposed patch to fix that as the
proposed format wasn't correct. HIGH MASK was being changed to use %u
instead of %x, which I thought was unintended.)

David

Commits

  1. Remove HASH_DEBUG output from dynahash.c

  2. Use elog(DEBUG4) for dynahash.c statistics output

  3. Fix invalid format string in HASH_DEBUG code

  4. Fix failing -D HASH_STATISTICS builds

  5. Refactor initial hash lookup in dynahash.c

  6. Remove large fill factor support from dynahash.c.

  7. Remove broken and useless entry-count printing in HASH_DEBUG code.

  8. Partition the freelist for shared dynahash tables.