Re: Avoid lost result of recursion (src/backend/optimizer/util/inherit.c)
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Ranier Vilela <ranier.vf@gmail.com>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-12-22T09:21:51Z
Lists: pgsql-hackers
On Thu, 22 Dec 2022 at 21:18, Richard Guo <guofenglinux@gmail.com> wrote: > My best guess is that this function is intended to share the same code > pattern as in adjust_appendrel_attrs_multilevel. The recursion is > needed as 'rel' can be more than one inheritance level below the top > parent. I think we can keep the recursion, as in other similar > functions, as long as we make it right, as in attached patch. I still think we should have a test to ensure this is actually working. Do you want to write one? David
Commits
-
Fix bug in translate_col_privs_multilevel
- bbfdf7180de8 16.0 landed
-
Rework query relation permission checking
- a61b1f74823c 16.0 cited