Re: wrong comments in ClassifyUtilityCommandAsReadOnly

On Mon, 23 Dec 2024 at 16:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > + *     The "DefineAggregate" routine take the parse tree and pick out the
> > + *     appropriate arguments/flags, passing the results to
> > + *     "AggregateCreate" routine (src src/backend/catalog) that do the actual
> > + *     catalog-munging.  These routines also verify permission of the user to
> > + *     execute the command.
>
> The grammar needs some help here.

Ah oops. I forgot to check that before posting.

> Also, rather than simply remove
> define.c's entire header comment, maybe we should write something
> relevant about what it does?  Good catches otherwise.

I didn't have any inspiration on what to write other than what's
already written on line 4.  Another reason I deleted that is that
since the file contains helper functions, I didn't want to write a new
comment based on what functions are there now as it may put someone
else off from adding new ones if the new one doesn't fit the comment.

I'm happy to take suggestions if you can think of something. In the
meantime, I've attached the patch with the aggregatecmds.c comment
fixes.

David