Re: Reduce the number of special cases to build contrib modules on windows

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Andres Freund <andres@anarazel.de>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>

Date: 2020-12-29T21:07:29Z

Lists: pgsql-hackers

Attachments

reduce_contrib_build_special_cases_on_windows_v6.patch (text/plain) patch v6

On Wed, 30 Dec 2020 at 10:03, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Wed, 23 Dec 2020 at 18:46, Michael Paquier <michael@paquier.xyz> wrote:
> > I have tested your patch, and this is causing compilation failures for
> > hstore_plpython, jsonb_plpython and ltree_plpython.  So
> > AddTransformModule is missing something here when compiling with
> > Python.
>
> Oh thanks for finding that.  That was due to some incorrect Perl code
> I'd written to add the includes from one project into another. Fixed
> by:

I accidentally attached the wrong patch before.  Now attaching the correct one.

David

Commits

Remove some special cases from MSVC build scripts
- 76ad24400d73 15.0 landed
Adjust MSVC build scripts to parse Makefiles for defines
- 245de48455da 15.0 landed
Don't duplicate references and libraries in MSVC scripts
- 15f16ec6511c 15.0 landed
Make the includes field an array in MSVC build scripts
- 33d74c5d00e4 15.0 landed
Use the AddFile function consistently in MSVC build scripts
- ed1884a2fede 15.0 landed
Remove seemingly unneeded include directory in MSVC scripts
- 4b763ff642e1 15.0 landed