Re: Some clean-up work in get_cheapest_group_keys_order()
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>
Date: 2022-07-13T00:50:52Z
Lists: pgsql-hackers
On Wed, 13 Jul 2022 at 11:02, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > David Rowley <dgrowleyml@gmail.com> writes: > > * I think list_truncate(list_copy(list), n) is a pretty bad way to > > copy the first n elements of a list, especially when n is likely to be > > 0 most of the time. I think we should just add a function called > > list_copy_head(). We already have list_copy_tail(). > > Agreed, but I think there are other instances of that idiom that > should be cleaned up while you're at it. Agreed. I imagine we should just do the remaining cleanup in master only. Do you agree? David
Commits
-
Use list_copy_head() instead of list_truncate(list_copy(...), ...)
- c23e3e6beb27 16.0 landed
-
Tidy up code in get_cheapest_group_keys_order()
- 44b5d5625389 15.0 landed
- 4cc832f94a58 16.0 landed