Re: Don't use bms_membership in places where it's not needed
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-27T23:16:21Z
Lists: pgsql-hackers
On Tue, 28 Nov 2023 at 11:21, Andres Freund <andres@anarazel.de> wrote: > Hm, does this ever matter from a performance POV? The current code does look > simpler to read to me. If the overhead is relevant, I'd instead just move the > code into a static inline? I didn't particularly find the code in examine_variable() easy to read. I think what's there now is quite a bit better than what was there. bms_get_singleton_member() was added in d25367ec4 for this purpose, so it seems kinda weird not to use it. David
Commits
-
Don't use bms_membership() in cases where we don't need to
- 930d2b442ff1 17.0 landed