Horton
Menu

Re: StringInfo fixes, v19 edition. Plus a few oddities

David Rowley <dgrowleyml@gmail.com>

View thread
From: David Rowley <dgrowleyml@gmail.com>
To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>
Date: 2026-04-13T01:18:11Z
Lists: pgsql-hackers 
On Sun, 12 Apr 2026 at 12:40, David Rowley <dgrowleyml@gmail.com> wrote:
> All of these changes in 0003 are in code that was touched since the
> last time I fixed these in 928394b66. However, the test_escape.c one
> added in 627acc3ca is in v18 as it was added after 928394b66 and
> before we branched for v19. Almost all of the describe.c ones were
> introduced in 41d69e6dc. These ones technically did exist in prior
> versions. They're only being highlighted now because the function
> changed from printfPQExpBuffer to appendPQExpBuffer, and I must not
> have made my StaticAsserts work for printfPQExpBuffer.  I left these
> in anyway since that code was touched in v19, and future bug fixes
> might conflict because of those changes anyway.

I've pushed the 0003 patch.

David

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Simplify translatable messages for tuple value details in conflict.c.

  2. Improve various new-to-v19 appendStringInfo calls