Re: Record a Bitmapset of non-pruned partitions
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Amit Langote <amitlangote09@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-01T22:20:40Z
Lists: pgsql-hackers
Thanks for having a look at this. On Mon, 2 Aug 2021 at 02:33, Zhihong Yu <zyu@yugabyte.com> wrote: > Here we look for partitions which > + * might be interleaved with other partitions and set the > + * interleaved_parts field with the partition indexes of any partitions > + * which may be interleaved with another partition. > > The above seems a little bit repetitive. It can be shortened to remove repetition. I agree that the word "partition" is mentioned quite a few times. The only one I can see that could be removed is the "partition indexes" one. Likely the details about which bit we set can be left up to the struct field comment in partbounds.h I've adjusted this to become: /* * Calculate interleaved partitions. Here we look for partitions which * might be interleaved with other partitions and set a bit in * interleaved_parts for any partitions which may be interleaved with * another partition. */ David
Commits
-
Ensure interleaved_parts field is always initialized
- 16239c5fdf6e 15.0 landed
-
Allow ordered partition scans in more cases
- db632fbca392 15.0 landed
-
Track a Bitmapset of non-pruned partitions in RelOptInfo
- 475dbd0b718d 15.0 landed