Re: Differential code coverage between 16 and HEAD

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Date: 2024-04-15T22:26:57Z
Lists: pgsql-hackers

Attachments

On Mon, 15 Apr 2024 at 10:33, Andres Freund <andres@anarazel.de> wrote:
> - The new bump allocator has a fair amount of uncovered functionality:
>   https://anarazel.de/postgres/cov/16-vs-HEAD-2024-04-14/src/backend/utils/mmgr/bump.c.gcov.html#L293

The attached adds a test to tuplesort to exercise BumpAllocLarge()

>   https://anarazel.de/postgres/cov/16-vs-HEAD-2024-04-14/src/backend/utils/mmgr/bump.c.gcov.html#L613

I don't see a way to exercise those. They're meant to be "can't
happen" ERRORs.  I could delete them and use BogusFree, BogusRealloc,
BogusGetChunkContext, BogusGetChunkSpace instead, but the ERROR
message would be misleading. I think it's best just to leave this.

David

Commits

  1. Push dedicated BumpBlocks to the tail of the blocks list

  2. Improve test coverage in bump.c