Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Englishify comment wording

  1. Minor spelling fix in memnodes.h

    Rafia Sabih <rafia.pghackers@gmail.com> — 2025-10-17T07:39:25Z

    Hello,

Came across this spelling error alloced -> allocated.
Patch for the fix is attached.

-- 
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH

  2. Re: Minor spelling fix in memnodes.h

    David Rowley <dgrowleyml@gmail.com> — 2025-10-17T09:18:36Z

    On Fri, 17 Oct 2025 at 20:39, Rafia Sabih <rafia.pghackers@gmail.com> wrote:
> Came across this spelling error alloced -> allocated.
> Patch for the fix is attached.

I suspect it is written as Tom intended it. The callback function in
MemoryContextMethods is called 'alloc' so I guess "alloced" is the
function name as a verb.

Maybe it's worth changing if there's confusion.

David

  3. Re: Minor spelling fix in memnodes.h

    Daniel Gustafsson <daniel@yesql.se> — 2025-10-17T09:22:25Z

    > On 17 Oct 2025, at 11:18, David Rowley <dgrowleyml@gmail.com> wrote:
> 
> On Fri, 17 Oct 2025 at 20:39, Rafia Sabih <rafia.pghackers@gmail.com> wrote:
>> Came across this spelling error alloced -> allocated.
>> Patch for the fix is attached.
> 
> I suspect it is written as Tom intended it.

+1, that was my conclusion as well.  While I'm personally not a fan of the use,
there are more comments using it as well as variables and struct members.

--
Daniel Gustafsson

  4. Re: Minor spelling fix in memnodes.h

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-10-17T14:37:22Z

    David Rowley <dgrowleyml@gmail.com> writes:
> On Fri, 17 Oct 2025 at 20:39, Rafia Sabih <rafia.pghackers@gmail.com> wrote:
>> Came across this spelling error alloced -> allocated.
>> Patch for the fix is attached.

> I suspect it is written as Tom intended it. The callback function in
> MemoryContextMethods is called 'alloc' so I guess "alloced" is the
> function name as a verb.

Yeah, it's not a typo but an intentional abbreviation.  Having said
that, I don't have any objection to changing it, especially since
there's now a use of "allocated" just two lines away.

I suspect that I shortened it to "alloced" in service of keeping the
comment on one line ... but it looks like it'd still fit if we added
the additional two characters.

			regards, tom lane

  5. Re: Minor spelling fix in memnodes.h

    David Rowley <dgrowleyml@gmail.com> — 2025-10-17T23:51:22Z

    On Sat, 18 Oct 2025 at 03:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > I suspect it is written as Tom intended it. The callback function in
> > MemoryContextMethods is called 'alloc' so I guess "alloced" is the
> > function name as a verb.
>
> Yeah, it's not a typo but an intentional abbreviation.  Having said
> that, I don't have any objection to changing it, especially since
> there's now a use of "allocated" just two lines away.

Sounds good. I've pushed the patch.

David