Horton

Thread

Commits

  1. Fix incorrect comment in pg_get_partkeydef()

  1. Inaccurate comment for pg_get_partkeydef

    Japin Li <japinli@hotmail.com> — 2023-03-06T05:54:27Z

    PSA patch to fix a comment inaccurate.

-- 
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

  2. Re: Inaccurate comment for pg_get_partkeydef

    Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> — 2023-03-06T14:30:03Z

    Looks good to me. Fixed according to the actual output.

select pg_get_partkeydef('prt1'::regclass);
 pg_get_partkeydef
-------------------
 RANGE (a)
(1 row)

bdrdemo@342511=#\d+ prt1
                                    Partitioned table "public.prt1"
 Column |  Type   | Collation | Nullable | Default | Storage |
Compression | Stats target | Description
--------+---------+-----------+----------+---------+---------+-------------+--------------+-------------
 a      | integer |           | not null |         | plain   |
    |              |
 b      | integer |           |          |         | plain   |
    |              |
Partition key: RANGE (a)
Indexes:
    "prt1_pkey" PRIMARY KEY, btree (a)
    "prt1_b" btree (b)
Partitions: prt1_p1 FOR VALUES FROM (0) TO (10),
            prt1_p2 FOR VALUES FROM (10) TO (20),
            prt1_default DEFAULT

On Mon, Mar 6, 2023 at 11:24 AM Japin Li <japinli@hotmail.com> wrote:
>
>
> PSA patch to fix a comment inaccurate.
>
> --
> Regrads,
> Japin Li.
> ChengDu WenWu Information Technology Co.,Ltd.
>


-- 
Best Wishes,
Ashutosh Bapat

  3. Re: Inaccurate comment for pg_get_partkeydef

    David Rowley <dgrowleyml@gmail.com> — 2023-03-07T01:35:03Z

    On Mon, 6 Mar 2023 at 18:54, Japin Li <japinli@hotmail.com> wrote:
> PSA patch to fix a comment inaccurate.

Thanks. Pushed.

David