Re: Incorrect comment regarding command completion tags
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2022-10-14T01:39:23Z
Lists: pgsql-hackers
On Fri, 14 Oct 2022 at 11:38, Mark Dilger <mark.dilger@enterprisedb.com> wrote: > > > On Oct 13, 2022, at 2:56 PM, David Rowley <dgrowleyml@gmail.com> wrote: > > In the attached, I rewrote the comment to remove mention of the > > Asserts. I also tried to form the comment in a way that's more > > understandable about why we always write a "0" in "INSERT 0 <nrows>". > > Your wording is better. +1 Thanks for having a look. I adjusted the wording slightly as I had written "ancient" in regards to PostgreSQL 11 and earlier. It's probably a bit early to call a supported version of PostgreSQL ancient so I just decided to mention the version number instead. I pushed the resulting patch. Thanks for having a look. David
Commits
-
Fix incorrect comment regarding command completion tags
- 39b8c293fcde 16.0 landed