Re: Align memory context level numbering in pg_log_backend_memory_contexts()
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Rahila Syed <rahilasyed90@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-17T21:11:38Z
Lists: pgsql-hackers
On Fri, 18 Apr 2025 at 00:25, Rahila Syed <rahilasyed90@gmail.com> wrote: > Regarding v2 patch, > - int level = 0; > > Retaining the level variable will enhance the code readability, IMO. When I read that, I suspected it might have been leftover from a refactor during the development that was forgotten about. There'd be thousands of places in our code base that you could make the readability argument for, including the max_level and max_children parameters at the same call-site. But those didn't get the same treatment. I've now pushed the latest patch. Thanks for the reviews. David
Commits
-
doc: Fix memory context level in pg_log_backend_memory_contexts() example.
- 706cbed35103 18.0 landed
-
Make levels 1-based in pg_log_backend_memory_contexts()
- d9e03864b6b4 18.0 landed
-
Add path column to pg_backend_memory_contexts view
- 32d3ed8165f8 18.0 cited