Horton

Re: Wrong unsafe-flag test in check_output_expressions()

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-02T22:32:43Z
Lists: pgsql-hackers 
On Wed, 3 Jun 2026 at 10:13, Richard Guo <guofenglinux@gmail.com> wrote:
>
> On Wed, Jun 3, 2026 at 5:59 AM David Rowley <dgrowleyml@gmail.com> wrote:
> > Yes, that's not intentional. Your proposed fix looks correct. Are you
> > happy to go ahead with pushing and backpatching that?
>
> Thanks for taking a look.  Yeah, I'm happy to push that.  I'm kind of
> unsure whether this needs to be back-patched, since it doesn't lead to
> wrong plans, so it isn't a live bug in practice.

I'd prefer it to be fully gone in all versions that have it, if you
don't mind doing that.

David

Commits

  1. Fix wrong unsafe-flag test in check_output_expressions()