Re: Incorrect Assert in BufFileSize()?

On Thu, 4 Jul 2024 at 04:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> - * Return the current fileset based BufFile size.
> + * Returns the size if the given BufFile in bytes.
>
> "Returns the size of", no doubt?

Yes, thanks.

> A shade less nit-pickily, I wonder if "size" is sufficient.
> It's not really obvious that this means the amount of data
> in the file, rather than say sizeof(BufFile).  How about
>
> + * Returns the amount of data in the given BufFile, in bytes.

I've used that. Thank you.

> LGTM other than that point.

Pushed.

David