Re: "an SQL" vs. "a SQL"
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Dave Page <dpage@pgadmin.org>,
Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-10T14:04:47Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Doc: use "an SQL" consistently rather than "a SQL"
- a78cf591a3f5 19 (unreleased) landed
- d866f0374ca6 16.0 landed
- 7bdd489d3d32 15.0 landed
-
Doc: use "an SQL" instead of "a SQL"
- b1b13d2b524e 17.0 landed
-
Use the correct article for abbreviations
- 04539e73faaa 14.0 landed
Attachments
- use_correct_article_with_vowel_sounding_abbreviations.patch (application/octet-stream) patch
On Thu, 10 Jun 2021 at 20:58, Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 10 Jun 2021, at 10:54, Dave Page <dpage@pgadmin.org> wrote: > > > .. I would perhaps suggest extending to any user-visible messages in the code. > > I agree, consistent language between docs and user-facing messages is > important. Yeah, agreed. I came up with the attached patch. The only additional abbreviation that I found to be incorrect that I'd previously not mentioned was "SRF". I changed that to use "an". I only found 4 error messages that needed to be updated. There's some incorrect stuff remaining in a few README files which I couldn't decide if I should update or not. Most of the offenders away from the docs are the translator hint comments and within the .po files themselves. $ git grep -E "translator:.*(a|A)\sSQL" | wc -l 690 Only 816 instances of "a SQL" remain, so only 126 are not related to translator hints or .po files. Does anyone have any thoughts if the READMEs should be fixed up? David