Horton
Menu

Re: Typos in the code and README

David Rowley <dgrowleyml@gmail.com>

View thread
From: David Rowley <dgrowleyml@gmail.com>
To: Alexander Lakhin <exclusion@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Nazir Bilal Yavuz <byavuz81@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2024-08-12T11:59:31Z
Lists: pgsql-hackers

Attachments

(I know Daniel mentioned he'd get to these, but the ScanDirection one
was my fault and I needed to clear that off my mind. I did a few
others while on this topic.)

On Fri, 5 Jul 2024 at 05:00, Alexander Lakhin <exclusion@gmail.com> wrote:
> Please look at another bunch of inconsistencies/orphaned entities I found
> in the tree, with the possible substitutions:
> errmsg_buf -> errormsg_buf
> (coined by 6b18b3fe2)

Fixed.

> NoMovementScanDirectionScans -> NoMovementScanDirection
> (introduced with e9aaf0632, discussed in [1], but still seems inaccurate)

Oops. Fixed.

> XLogReadRecordInternal -> XLogReadRecord
> (from 3f1ce9734, align with a comment above: "Start and end point of last
> record returned by XLogReadRecord().")

Fixed.

> BYPASS_ALLOWCONN -> BGWORKER_BYPASS_ROLELOGINCHECK (see 492217301)

Fixed

> xs_ctup.t_self -> xs_heaptid (see c2fe139c2 and 304532421)

Fixed.

> pgStatShmLookupCache -> pgStatLocal.shmem (coined by 5891c7a8e)

Fixed.

> smgr_fsm_nblocks and smgr_vm_nblocks -> smgr_cached_nblocks
> (see the same comment updated by c5315f4f4)

Heikki fixed in 19de089cd.

> XID becomes older than GlobalXmin -> XID becomes visible to everyone
> (in accordance with dc7420c2c9 src/backend/access/gist/gistutil.c)

I'd need to spend more time to understand this.

> gen-rtab - remove (non-existing since db7d1a7b0)

Daniel fixed in cc59f9d0f.

> BARRIER_SHOULD_CHECK - remove (unused since a3ed4d1ef)

I wasn't sure if nothing else external could be using this. The macro
doesn't use any fields that are now gone, so I'm not confident enough
to remove it. Can Robert confirm?

> EXE_EXT - remove (unused since f06b1c598)

Daniel fixed in 88e3da565.

> endterm - remove
> (see 60c90c16c -- Use xreflabel attributes instead of endterm ...)

I read that commit message and I agree it's now unused. I just didn't
get any vibes from the commit message that it shouldn't ever be used
again.  Can Tom confirm?

> xl_commit_ts_set, SizeOfCommitTsSet - remove (unused since 08aa89b32)

I would say it should be removed.  I just didn't because the commit I
had pending fitted into the "typos" category and this didn't quite
fit.

I've attached a patch with the remainder.

David

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in planner.c

  2. Fix meson build of snowball code.

  3. Update to latest Snowball sources.

  4. Remove unneeded defines from pg_config.h.in

  5. Fix typos and inconsistencies in code and comments

  6. Fix a few more duplicate words in comments

  7. Fix a few duplicate words in comments

  8. Fix typos and grammar in the code

  9. Fix an assortment of spelling mistakes and typos

  10. Fix inconsistent LWLock tranche name "CommitTsSLRU"

  11. Fix typos in code comments and test data

  12. Fix typos and grammar in code comments and docs

  13. Fix a series of typos and outdated references

  14. Optimize InvalidateAttoptCacheCallback() and TypeCacheTypCallback()

  15. pg_upgrade: Remove unused macro

  16. pgcrypto: Remove unused binary from clean target

  17. Fix an assortment of typos

  18. Fix duplicated consecutive words in comments

  19. Remove unused function prototype

  20. Fix incorrect parameter name in prototype

  21. Fix typos and duplicate words

  22. Speedup 2PC recovery by skipping two phase state files in normal path

  23. Two-phase commit. Original patch by Heikki Linnakangas, with additional