Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

David Rowley <dgrowleyml@gmail.com>

From: David Rowley <dgrowleyml@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Steve Lau <stevelauc@outlook.com>, pgsql-hackers@postgresql.org
Date: 2025-09-22T00:49:19Z
Lists: pgsql-hackers
On Mon, 22 Sept 2025 at 11:56, Richard Guo <guofenglinux@gmail.com> wrote:
>
> On Sun, Sep 21, 2025 at 11:54 PM Steve Lau <stevelauc@outlook.com> wrote:
> > Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:
> >
> > > join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the
>
> Nice catch.  Will push the patch.

I was just working on a script to find others and it highlighted a
bunch more. Do you still want to do this one, or should I take them
all in one fell swoop?

David



Commits

  1. Fix misleading comment in RangeTblEntry