Horton
Menu

Re: BUG #18914: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison '0' > 'nb' (0 > {4, 16}) is always false

David Rowley <dgrowleyml@gmail.com>

View thread
From: David Rowley <dgrowleyml@gmail.com>
To: gorcom2012@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-05-07T10:34:16Z
Lists: pgsql-bugs 
On Wed, 7 May 2025 at 21:28, PG Bug reporting form
<noreply@postgresql.org> wrote:
> @@ -279,8 +279,7 @@ network_send(inet *addr, bool is_cidr)
>         pq_sendbyte(&buf, ip_bits(addr));
>         pq_sendbyte(&buf, is_cidr);
>         nb = ip_addrsize(addr);
> -       if (nb < 0)
> -               nb = 0;
> +       Assert(nb >= 0);


This has already been fixed in master by [1]. Since there's no actual
misbehaviour, there was no backpatch.

David

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f27eb0325b7b2cff3b880fa669913693849521dc

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove useless check for negative result of ip_addrsize().