Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Guillaume Lelarge <guillaume@lelarge.info>,
Greg Sabino Mullane <htamfids@gmail.com>, Michael Christofides <michael@pgmustard.com>,
"David G. Johnston" <david.g.johnston@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
pgsql-hackers@postgresql.org
Date: 2024-11-25T22:52:34Z
Lists: pgsql-hackers
On Tue, 26 Nov 2024 at 09:44, Robert Haas <robertmhaas@gmail.com> wrote: > > On Wed, Nov 20, 2024 at 4:23 PM David Rowley <dgrowleyml@gmail.com> wrote: > > I think this might be a good time for anyone out there who is against > > turning on BUFFERS when ANALYZE is on to speak up. > > > > Votes for changing this so far seem to be: Me, Michael Christofides, > > Guillaume Lelarge, Robert, Greg Sabino Mullane, and David Fetter (from > > 2020) [1]. > > > > Votes against: None > > Just to be clear, my vote is more like +0 than +1. I recognize that > changing this is popular and I'm not opposed to it, but I'm also not > unhappy with things as they are. OK, thanks. I likely took your neutrality here in a more positive light after reading the 4-year-old message at [1]. That probably wasn't the right thing to do. There are still no votes against it, so unless some come in, I plan to start looking at the patches proposed to turn buffers on with analyze with my committer hat on. David [1] https://www.postgresql.org/message-id/CA%2BTgmoYH_p-y%3D45SAJ58cU6jsMH6ojgqQZiA2aePpvZ0J%2BuLbA%40mail.gmail.com
Commits
-
Fix further fallout from EXPLAIN ANALYZE BUFFERS change
- 89988ac5891b 18.0 landed
-
Add missing BUFFERS OFF in regression tests, take 2
- 9df2a4b9316f 18.0 landed
-
Add missing BUFFERS OFF in select_into regression tests
- 9fa1aaa6525a 18.0 landed
-
Enable BUFFERS with EXPLAIN ANALYZE by default
- c2a4078ebad7 18.0 landed