Horton

Re: Correction of RowMark Removal During Sel-Join Elimination

David Rowley <dgrowleyml@gmail.com>

View thread View on postgr.es
From: David Rowley <dgrowleyml@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andrei Lepikhov <lepihov@gmail.com>, Greg Sabino Mullane <htamfids@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alexander Lakhin <exclusion@gmail.com>
Date: 2026-01-04T08:38:06Z
Lists: pgsql-hackers 
On Sun, 31 Aug 2025 at 13:04, Richard Guo <guofenglinux@gmail.com> wrote:
>
> On Sun, Aug 31, 2025 at 9:50 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
> > On Sun, Aug 31, 2025 at 2:51 AM Richard Guo <guofenglinux@gmail.com> wrote:
> > > I think it's better to push this patch sooner rather than later, as
> > > multiple people have encountered the issue in different ways.  I'll go
> > > ahead and push 0001 from my patch set shortly.
>
> > I see.  You're much farther than I'm.  Please, go ahead pushing this.
>
> Done.

Is there anything left for this thread now? There's still a CF entry
[1] for this. Can the status be updated according to the current
situation? I see the CF entry's tags claim this is a "BugFix" and
"Refactoring Only". It can't be both of those. If work still needs to
be done here, can the tags also be fixed?

David

[1] https://commitfest.postgresql.org/patch/5943/

Commits

  1. Improve RowMark handling during Self-Join Elimination

  2. Refactor variable names in remove_self_joins_one_group()

  3. Reduce "Var IS [NOT] NULL" quals during constant folding

  4. Reimplement parsing and storage of default expressions and constraint