Re: BUG #15548: Unaccent does not remove combining diacritical characters

Hugh Ranalli <hugh@whtc.ca>

From: Hugh Ranalli <hugh@whtc.ca>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, thomas.munro@enterprisedb.com, Daniel Verite <daniel@manitou-mail.org>, pgsql-bugs@lists.postgresql.org
Date: 2019-01-04T16:29:42Z
Lists: pgsql-bugs, pgsql-hackers
On Fri, 4 Jan 2019 at 08:00, Michael Paquier <michael@paquier.xyz> wrote:

> I haven't been able to finish what I wanted for the proposed patch set
> yet, but what I was thinking about is to include:
> 1) The root URL where all the release folders are present
> 2) The full URL of the current Latin-ASCII.xml being used for the
> generation, not as a URL pointing to the latest version, but as a URL
> pointing to an exact version in time (I doubt that a released version
> never changes in this tree, but who knows..).
> 3) The version used to generate the rules.
>

Hi Michael,
I think we're on the same page. I'll wait for you to finish your review and
provide any further comments before I make any changes.

Thanks,
Hugh

Commits

  1. Fix unaccent generation script in Windows

  2. Add combining characters to unaccent.rules.

  3. Update unaccent rules with release 34 of CLDR for Latin-ASCII.xml

  4. unaccent: Make generate_unaccent_rules.py Python 3 compatible

  5. Convert unaccent tests to UTF-8