Horton

Re: BUG #15548: Unaccent does not remove combining diacritical characters

Hugh Ranalli <hugh@whtc.ca>

View thread View on postgr.es
From: Hugh Ranalli <hugh@whtc.ca>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: thomas.munro@enterprisedb.com, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Verite <daniel@manitou-mail.org>, pgsql-bugs@lists.postgresql.org
Date: 2019-01-02T17:58:03Z
Lists: pgsql-bugs, pgsql-hackers 
On Wed, 2 Jan 2019 at 12:41, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

> On 20/12/2018 23:39, Hugh Ranalli wrote:
> > 01 - Updates generate_unaccent_rules.py to be Python 2 and 3 compatible.
>
> My opinion is that we should just convert the whole thing to Python 3
> and be done.  This script is only run rarely, on a developer's machine,
> so it's not unreasonable to expect Python 3 to be available.
>

Well, this is definitely an edge case, but I am actually running the
patched script from a complex application installer running a
custom-compiled version of Python 2.7. The installer runs under the same
Python instance as the application. I certainly could invoke Python 3 to
run this script, it's just a little more work, so I'm happy to go with the
team's decision. Just let me know.

Hugh

Commits

  1. Fix unaccent generation script in Windows

  2. Add combining characters to unaccent.rules.

  3. Update unaccent rules with release 34 of CLDR for Latin-ASCII.xml

  4. unaccent: Make generate_unaccent_rules.py Python 3 compatible

  5. Convert unaccent tests to UTF-8