Re: BUG #15548: Unaccent does not remove combining diacritical characters
Hugh Ranalli <hugh@whtc.ca>
From: Hugh Ranalli <hugh@whtc.ca>
To: raam narayana <raam.soft@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-02-11T19:20:42Z
Lists: pgsql-bugs, pgsql-hackers
On Sun, 10 Feb 2019 at 15:07, raam narayana <raam.soft@gmail.com> wrote: > Hi, > > After the latest commit in master branch, I was trying to test the python > script. Ironically I still see that the output from the script is > completely different from the unaccent.rules file content. Am I missing > anything.My testing includes the following > > Downloaded the following files > > http://unicode.org/Public/8.0.0/ucd/UnicodeData.txt > > > http://unicode.org/cldr/trac/export/14746/tags/release-34/common/transforms/Latin-ASCII.xml > > Executed the below python script > > python generate_unaccent_rules.py --unicode-data-file UnicodeData.txt > --latin-ascii-file Latin-ASCII.xml > unaccent.rules > > I am using python 3.7.1 and running on Windows 10 Platform > > The new status of this patch is: Needs review > Hi Raam, I just ran generate_unaccent_rules.py under two environments, using the data files given above : - Python 3.4.3 on Linux Mint 17.3 (equivalent to Ubuntu 14.04) - Python 3.6.7 on Ubuntu 18.04 In both cases, the output was identical to that generated by the program under Python 2.7. So yes, more information would help. Unfortunately I don't have a Windows Python environment readily available, but could set one up if I had to. Thanks, Hugh
Commits
-
Fix unaccent generation script in Windows
- 0afc0a784188 13.0 landed
-
Add combining characters to unaccent.rules.
- 456e3718e7b7 12.0 landed
-
Update unaccent rules with release 34 of CLDR for Latin-ASCII.xml
- e1c1d5444e43 12.0 landed
-
unaccent: Make generate_unaccent_rules.py Python 3 compatible
- 3d59da9ccdb9 12.0 landed
-
Convert unaccent tests to UTF-8
- b6f3649bba98 12.0 landed