Re: BUG #15548: Unaccent does not remove combining diacritical characters
Hugh Ranalli <hugh@whtc.ca>
From: Hugh Ranalli <hugh@whtc.ca>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
thomas.munro@enterprisedb.com, Daniel Verite <daniel@manitou-mail.org>, pgsql-bugs@lists.postgresql.org
Date: 2019-01-10T14:10:43Z
Lists: pgsql-bugs, pgsql-hackers
On Thu, 10 Jan 2019 at 01:09, Michael Paquier <michael@paquier.xyz> wrote: > OK, committed then. I have yet to study yet the other part of the > proposal regarding diatritical characters. Patch 3 has a conflict for > the regression tests, so a rebase would be needed. That's not a big > deal though to resolve the conflict. I am also a bit confused by the > newly-generated unaccent.rules. Why nothing shows up for the second > column (around line 414 for example)? Shouldn't we have mapping > characters? > That concerned me, as well. I have confirmed the lines are not empty. If you open the file in a text editor (I'm using KDE's Kate), and insert a standard character at the beginning of one of those lines, the diacritic then appears, combined with the character you just entered. The only program I've found that wants to display them on their own is vi (and I only just thought of trying that). From what I can tell, this is likely a font issue: - http://unicode.org/faq/char_combmark.html#12b - https://superuser.com/questions/852901/why-are-some-combining-diacritics-shifted-to-the-right-in-some-programs Hugh
Commits
-
Fix unaccent generation script in Windows
- 0afc0a784188 13.0 landed
-
Add combining characters to unaccent.rules.
- 456e3718e7b7 12.0 landed
-
Update unaccent rules with release 34 of CLDR for Latin-ASCII.xml
- e1c1d5444e43 12.0 landed
-
unaccent: Make generate_unaccent_rules.py Python 3 compatible
- 3d59da9ccdb9 12.0 landed
-
Convert unaccent tests to UTF-8
- b6f3649bba98 12.0 landed