Re: Amcheck verification of GiST and GIN

Andrey Borodin <amborodin86@gmail.com>

From: Andrey Borodin <amborodin86@gmail.com>

To: Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, Andrey Borodin <x4mmm@yandex-team.ru>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-11-28T01:07:40Z

Lists: pgsql-hackers

Attachments

v17-0002-Add-gist_index_parent_check-function-to-verify-G.patch (application/octet-stream) patch v17-0002
v17-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch (application/octet-stream) patch v17-0003
v17-0001-Refactor-amcheck-to-extract-common-locking-routi.patch (application/octet-stream) patch v17-0001

On Sun, Nov 27, 2022 at 1:29 PM Andrey Borodin <amborodin86@gmail.com> wrote:
>
> GiST verification checks only one invariant that can be verified if
> page locks acquired the same way as page split does.
> GIN does not require ShareLock because it does not check cross-level invariants.
>

I was wrong. GIN check does similar gin_refind_parent() to lock pages
in bottom-up manner and truly verify downlink-child_page invariant.

Here's v17. The only difference is that I added progress reporting to
GiST verification.
I still did not implement heapallindexed for GIN. Existence of pending
lists makes this just too difficult for a weekend coding project :(

Thank you!

Best regards, Andrey Borodin.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Fix posting tree checks in gin_index_check()
- 0cf205e122ae 18.0 landed
amcheck: Fix parent key check in gin_index_check()
- cdd1a431f21d 18.0 landed
amcheck: Fix checks of entry order for GIN indexes
- 0b54b392334b 18.0 landed
amcheck: Remove unused GinScanItem->parentlsn field
- 8dd41c0bff5b 18.0 landed
amcheck: Test gin_index_check on a multicolumn index
- c89d6b889ce9 18.0 landed
Remove incidental md5() function use from test
- 49b82522f13f 18.0 landed
amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests
- 68f97aeadb8e 18.0 landed
amcheck: Add a test with GIN index on JSONB data
- ca738bdc4c9d 18.0 landed
amcheck: Fix indentation in verify_gin.c
- ec4327d106be 18.0 landed
amcheck: Add gin_index_check() to verify GIN index
- 14ffaece0fb5 18.0 landed
amcheck: Move common routines into a separate module
- d70b17636ddf 18.0 landed
Fix grammar in GIN README
- fb9dff76635d 18.0 landed
Avoid amcheck inline compression false positives.
- eba775345d23 12.0 cited