Re: psql \watch 2nd argument: iteration count
Andrey Borodin <amborodin86@gmail.com>
From: Andrey Borodin <amborodin86@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: sfrost@snowman.net, peter.eisentraut@enterprisedb.com, pgsql-hackers@postgresql.org
Date: 2023-02-27T04:55:45Z
Lists: pgsql-hackers
Attachments
- v3-0002-Add-iteration-count-argument-to-psql-watch-comman.patch (application/octet-stream) patch v3-0002
- v3-0001-Fix-incorrect-argument-handling-in-psql-watch.patch (application/octet-stream) patch v3-0001
Thanks for looking into this! On Mon, Feb 20, 2023 at 6:15 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote: > > FWIW the patch still accepts an incorrect parameter '1abc' > by ignoring any trailing garbage. Indeed, fixed. > > In any case, I reckon the error message should be more specific. In > other words, it would be better if it suggests the expected input > format and range. +1. Not a range, actually, because upper limits have no sense for a user. > > Regarding the second patch, if we want \watch to throw an error > message for the garbage trailing to sleep times, I think we should do > the same for iteration counts. +1, done. > Additionally, we need to update the > documentation. Done. Thanks for the review! Best regards, Andrey Borodin.
Commits
-
psql: add an optional execution-count limit to \watch.
- 00beecfe839c 16.0 landed
-
Improve handling of psql \watch's interval argument
- 6f9ee74d45aa 16.0 landed