Re: Amcheck verification of GiST and GIN

Andrey Borodin <amborodin86@gmail.com>

From: Andrey Borodin <amborodin86@gmail.com>

To: Peter Geoghegan <pg@bowt.ie>

Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>, Andres Freund <andres@anarazel.de>, Andrey Borodin <x4mmm@yandex-team.ru>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2023-03-26T22:17:02Z

Lists: pgsql-hackers

Attachments

v26-0001-Refactor-amcheck-to-extract-common-locking-routi.patch (application/octet-stream) patch v26-0001
v26-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch (application/octet-stream) patch v26-0003
v26-0004-Add-GiST-support-to-pg_amcheck.patch (application/octet-stream) patch v26-0004
v26-0002-Add-gist_index_check-function-to-verify-GiST-ind.patch (application/octet-stream) patch v26-0002

On Sun, Mar 19, 2023 at 4:00 PM Andrey Borodin <amborodin86@gmail.com> wrote:
>
> Also, there are INCLUDEd attributes. Right now we just put them as-is
> to the bloom filter. Does this constitute a TOAST bug as in B-tree?
> If so, I think we should use a version of tuple formatting that omits
> included attributes...
> What do you think?
I've ported the B-tree TOAST test to GiST, and, as expected, it fails.
Finds non-indexed tuple for a fresh valid index.
I've implemented normalization, plz see gistFormNormalizedTuple().
But there are two problems:
1. I could not come up with a proper way to pfree() compressed value
after decompressing. See TODO in gistFormNormalizedTuple().
2. In the index tuples seem to be normalized somewhere. They do not
have to be deformed and normalized. It's not clear to me how this
happened.

Thanks!

Best regards, Andrey Borodin.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Fix posting tree checks in gin_index_check()
- 0cf205e122ae 18.0 landed
amcheck: Fix parent key check in gin_index_check()
- cdd1a431f21d 18.0 landed
amcheck: Fix checks of entry order for GIN indexes
- 0b54b392334b 18.0 landed
amcheck: Remove unused GinScanItem->parentlsn field
- 8dd41c0bff5b 18.0 landed
amcheck: Test gin_index_check on a multicolumn index
- c89d6b889ce9 18.0 landed
Remove incidental md5() function use from test
- 49b82522f13f 18.0 landed
amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests
- 68f97aeadb8e 18.0 landed
amcheck: Add a test with GIN index on JSONB data
- ca738bdc4c9d 18.0 landed
amcheck: Fix indentation in verify_gin.c
- ec4327d106be 18.0 landed
amcheck: Add gin_index_check() to verify GIN index
- 14ffaece0fb5 18.0 landed
amcheck: Move common routines into a separate module
- d70b17636ddf 18.0 landed
Fix grammar in GIN README
- fb9dff76635d 18.0 landed
Avoid amcheck inline compression false positives.
- eba775345d23 12.0 cited