Re: Amcheck verification of GiST and GIN

Andrey Borodin <amborodin86@gmail.com>

From: Andrew Borodin <amborodin86@gmail.com>

To: Andres Freund <andres@anarazel.de>

Cc: Andrey Borodin <x4mmm@yandex-team.ru>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-10-08T22:36:52Z

Lists: pgsql-hackers

Attachments

v15-0002-Add-gist_index_parent_check-function-to-verify-G.patch (application/octet-stream) patch v15-0002
v15-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch (application/octet-stream) patch v15-0003
v15-0001-Refactor-amcheck-to-extract-common-locking-routi.patch (application/octet-stream) patch v15-0001

On Sun, Oct 2, 2022 at 12:12 AM Andres Freund <andres@anarazel.de> wrote:
>
> Here's an updated patch adding meson compat.

Thank you, Andres! Here's one more rebase (something was adjusted in
amcheck build).
Also I've fixed new warnings except warning about absent
heapallindexed for GIN. It's a TODO.

Thanks!

Best regards, Andrey Borodin.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Fix posting tree checks in gin_index_check()
- 0cf205e122ae 18.0 landed
amcheck: Fix parent key check in gin_index_check()
- cdd1a431f21d 18.0 landed
amcheck: Fix checks of entry order for GIN indexes
- 0b54b392334b 18.0 landed
amcheck: Remove unused GinScanItem->parentlsn field
- 8dd41c0bff5b 18.0 landed
amcheck: Test gin_index_check on a multicolumn index
- c89d6b889ce9 18.0 landed
Remove incidental md5() function use from test
- 49b82522f13f 18.0 landed
amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests
- 68f97aeadb8e 18.0 landed
amcheck: Add a test with GIN index on JSONB data
- ca738bdc4c9d 18.0 landed
amcheck: Fix indentation in verify_gin.c
- ec4327d106be 18.0 landed
amcheck: Add gin_index_check() to verify GIN index
- 14ffaece0fb5 18.0 landed
amcheck: Move common routines into a separate module
- d70b17636ddf 18.0 landed
Fix grammar in GIN README
- fb9dff76635d 18.0 landed
Avoid amcheck inline compression false positives.
- eba775345d23 12.0 cited