Horton

Re: Minimal logical decoding on standbys

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Jeff Davis <pgsql@j-davis.com>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, Amit Khandekar <amitdkhan.pg@gmail.com>, fabriziomello@gmail.com, tushar <tushar.ahuja@enterprisedb.com>, Rahila Syed <rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-04-08T06:52:27Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reduce the log level in 035_standby_logical_decoding.pl.

  2. 035_standby_logical_decoding: Add missing waits for replication

  3. For cascading replication, wake physical and logical walsenders separately

  4. Handle logical slot conflicts on standby

  5. Support invalidating replication slots due to horizon and wal_level

  6. Prevent use of invalidated logical slot in CreateDecodingContext()

  7. Replace replication slot's invalidated_at LSN with an enum

  8. Pass down table relation into more index relation functions

  9. Assert only valid flag bits are passed to visibilitymap_set()

  10. Remove unused _bt_delitems_delete() argument.

  11. Add xl_btree_delete optimization.

Hi,

New wording works for me, thanks!

Bertrand

Le sam. 8 avr. 2023, 08:26, Andres Freund <andres@anarazel.de> a écrit :

> Hi,
>
> On 2023-04-07 11:12:26 -0700, Andres Freund wrote:
> > +     <row>
> > +      <entry role="catalog_table_entry"><para role="column_definition">
> > +       <structfield>confl_active_logicalslot</structfield>
> <type>bigint</type>
> > +      </para>
> > +      <para>
> > +       Number of active logical slots in this database that have been
> > +       invalidated because they conflict with recovery (note that
> inactive ones
> > +       are also invalidated but do not increment this counter)
> > +      </para></entry>
> > +     </row>
> >      </tbody>
> >     </tgroup>
> >    </table>
>
> This seems wrong to me. The counter is not for invalidated slots, it's for
> recovery conflict interrupts. If phrased that way, the parenthetical would
> be
> unnecessary.
>
> I think something like
>        Number of uses of logical slots in this database that have been
>        canceled due to old snapshots or a too low <xref
> linkend="guc-wal-level"/>
>        on the primary
>
> would work and fit with the documentation of the other fields? Reads a bit
> stilted, but so do several of the other fields...
>
> Greetings,
>
> Andres Freund
>