Horton

Thread

Commits

  1. Fix some grammatical errors in some comments

  1. Fix grammar oddities in comments

    James Coleman <jtc331@gmail.com> — 2024-06-01T22:08:23Z

    Hi,

See attached for a small patch fixing some typos and grammatical
errors in a couple of comments.

Side note: It's not clear to me what "Vars of higher levels don't
matter here" means in this context (or how that claim is justified),
but I haven't changed that part of the comment opting to simply
resolve the clear mistakes in the wording here.

Regards,
James Coleman

  2. Re: Fix grammar oddities in comments

    David Rowley <dgrowleyml@gmail.com> — 2024-06-05T09:34:43Z

    On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331@gmail.com> wrote:
> See attached for a small patch fixing some typos and grammatical
> errors in a couple of comments.

Thanks. I pushed this after messing with the comments a bit more.

> Side note: It's not clear to me what "Vars of higher levels don't
> matter here" means in this context (or how that claim is justified),
> but I haven't changed that part of the comment opting to simply
> resolve the clear mistakes in the wording here.

It just means Vars with varlevelsup >= 2 don't matter. It only cares
about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct
parent.

David

  3. Re: Fix grammar oddities in comments

    Aaron Altman <aaronaltman@posteo.net> — 2024-06-08T22:04:44Z

    The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

Confirming linguistic correctness of changes, and lack of anything changed outside of comments that would otherwise affect readiness to commit.

The new status of this patch is: Ready for Committer

  4. Re: Fix grammar oddities in comments

    James Coleman <jtc331@gmail.com> — 2024-06-10T12:28:28Z

    On Wed, Jun 5, 2024 at 5:34 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331@gmail.com> wrote:
> > See attached for a small patch fixing some typos and grammatical
> > errors in a couple of comments.
>
> Thanks. I pushed this after messing with the comments a bit more.

Thanks!

> > Side note: It's not clear to me what "Vars of higher levels don't
> > matter here" means in this context (or how that claim is justified),
> > but I haven't changed that part of the comment opting to simply
> > resolve the clear mistakes in the wording here.
>
> It just means Vars with varlevelsup >= 2 don't matter. It only cares
> about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct
> parent.

Yes, I understood the content, but I didn't see any justification
provided, which is what I'd hope for in a comment like this (why not
simply what).

Anyway, thanks again for reviewing and committing.

James Coleman