Horton

Possible typo/unclear comment in joinpath.c

James Coleman <jtc331@gmail.com>

View thread View on postgr.es
From: James Coleman <jtc331@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-04-14T15:36:38Z
Lists: pgsql-hackers

Attachments

In joinpath.c three times we reference "extra_lateral_rels" (with
underscores like it's a field), but as far as I can tell that's not a
field anywhere in the source code, and looking at the code that
follows it seems like it should be referencing "lateral_relids" (and
the "extra" is really "extra [in relation to relids]").

Assuming that interpretation is correct, I'd attached a patch to
change all three occurrences to "extra lateral_relids" to reduce
confusion.

Thanks,
James

Commits

  1. Fix obsolete comments referencing JoinPathExtraData.extra_lateral_rels.

  2. Simplify LATERAL-related calculations within add_paths_to_joinrel().