Re: Possible typo/unclear comment in joinpath.c

On Wed, Apr 14, 2021 at 1:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > On Wed, Apr 14, 2021 at 11:36:38AM -0400, James Coleman wrote:
> >> In joinpath.c three times we reference "extra_lateral_rels" (with
> >> underscores like it's a field), but as far as I can tell that's not a
> >> field anywhere in the source code, and looking at the code that
> >> follows it seems like it should be referencing "lateral_relids" (and
> >> the "extra" is really "extra [in relation to relids]").
>
> > It looks like a loose end from
>
> > commit edca44b1525b3d591263d032dc4fe500ea771e0e
> > Author: Tom Lane <tgl@sss.pgh.pa.us>
> > Date:   Mon Dec 7 18:56:14 2015 -0500
>
> >     Simplify LATERAL-related calculations within add_paths_to_joinrel().
>
> Yeah :-(.  I'm usually pretty careful about grepping for comment
> references as well as code references to a field when I do something
> like that, but obviously I missed that step that time.
>
> Will fix, thanks James!
>
>                         regards, tom lane

Thanks for fixing, Tom!

James