Horton

Re: Add pg_freespacemap extension sql test

Dong Wook Lee <sh95119@gmail.com>

View thread
From: Dong Wook Lee <sh95119@gmail.com>
To: fabriziomello@gmail.com
Cc: pgsql-hackers@postgresql.org
Date: 2022-03-21T12:12:37Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid instabilities with the regression tests of pg_freespacemap

  2. Add some basic regression tests for pg_freespacemap

2022년 3월 20일 (일) 03:13, Fabrízio de Royes Mello <fabriziomello@gmail.com>님이
작성:

>
>
> On Sat, Mar 19, 2022 at 1:18 PM Dong Wook Lee <sh95119@gmail.com> wrote:
> >
> > > Well, my guess is that you basically just care about being able to
> > > detect if there is free space in the map or not, which goes down to
> > > detecting if pg_freespace() returns 0 or a number strictly higher than
> > > 0, so wouldn't it be enough to stick some > 0 in your test queries?
> >
> > I edited the previous patch file.
> > Am I correct in understanding that?
> >
>
> I think what Michael meant is something like attached.
>
> Regards,
>
> --
> Fabrízio de Royes Mello
>

I think you’re right, thank you for sending it instead of me.

>