Re: Add test of pg_prewarm extenion

Dong Wook Lee <sh95119@gmail.com>

From: Dong Wook Lee <sh95119@gmail.com>
To: Julien Rouhaud <rjuju123@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2022-08-01T14:33:38Z
Lists: pgsql-hackers

Attachments

Thank you for letting me know.
I edited my patch with `wait_for_log()`.

2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud <rjuju123@gmail.com>님이 작성:
>
> On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee <sh95119@gmail.com> wrote:
> >
> > > Keep in mind also that the logfile accumulates over stops and
> > > restarts.  As you've coded this test, you don't know which DB start
> > > emitted the matching line, so the test proves a lot less than it
> > > ought to.
> > >
> > > I wonder also about race conditions.  On fast machines, or those
> > > with weird schedulers, the test script might reach slurp_file
> > > before autoprewarm has had a chance to emit the log entry you want.
> >
> > I have no idea how to deal with race conditions.
> > Does anybody know how to deal with this?
>
> Couldn't you use $node->wait_for_log() instead?

Commits

  1. Add a regression test for contrib/pg_prewarm.