Horton

Thread

Commits

  1. pg_stat_statements: Remove unnecessary call to GetUserId()

  1. pg_stat_statements: remove redundant function call in pg_stat_statements_internal

    Dong Wook Lee <sh95119@gmail.com> — 2022-02-27T11:45:13Z

    Hi,

I found some redundant function calls in
pg_stat_statements.c/pg_stat_statements_internal(),
There is no need to call GetUserId() again because the value was
previously obtained.
so I propose a patch to fix it.

--- a/contrib/pg_stat_statements/pg_stat_statements.c
+++ b/contrib/pg_stat_statements/pg_stat_statements.c
@@ -1508,7 +1508,7 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo,
        pgssEntry  *entry;

        /* Superusers or members of pg_read_all_stats members are allowed */
-       is_allowed_role = is_member_of_role(GetUserId(),
ROLE_PG_READ_ALL_STATS);
+       is_allowed_role = is_member_of_role(userid, ROLE_PG_READ_ALL_STATS);

        /* hash table must exist already */
        if (!pgss || !pgss_hash)

Regards,
Lee Dong Wook.

  2. Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal

    Julien Rouhaud <rjuju123@gmail.com> — 2022-02-27T11:55:26Z

    Hi,

On Sun, Feb 27, 2022 at 08:45:13PM +0900, Dong Wook Lee wrote:
> 
> I found some redundant function calls in
> pg_stat_statements.c/pg_stat_statements_internal(),
> There is no need to call GetUserId() again because the value was
> previously obtained.

Indeed.  I doubt it will make any real difference but it doesn't hurt to fix
it.

Patch looks good to me.

  3. Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal

    Michael Paquier <michael@paquier.xyz> — 2022-02-27T12:08:56Z

    On Sun, Feb 27, 2022 at 07:55:26PM +0800, Julien Rouhaud wrote:
> Indeed.  I doubt it will make any real difference but it doesn't hurt to fix
> it.
> 
> Patch looks good to me.

Yes, let's clean up that on HEAD.  No objections from here.  I'll do
that tomorrow or so.
--
Michael

  4. Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal

    Michael Paquier <michael@paquier.xyz> — 2022-02-28T02:02:09Z

    On Sun, Feb 27, 2022 at 09:08:56PM +0900, Michael Paquier wrote:
> Yes, let's clean up that on HEAD.  No objections from here.  I'll do
> that tomorrow or so.

And done.
--
Michael