Horton

Re: [PoC] Let libpq reject unexpected authentication requests

Jacob Champion <jchampion@timescale.com>

View thread View on postgr.es
From: Jacob Champion <jchampion@timescale.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Aleksander Alekseev <aleksander@timescale.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "David G. Johnston" <david.g.johnston@gmail.com>
Date: 2023-03-10T23:16:20Z
Lists: pgsql-hackers 
On Fri, Mar 10, 2023 at 3:09 PM Michael Paquier <michael@paquier.xyz> wrote:
> >>      +                  reason = libpq_gettext("server did not complete authentication"),
> >>     -+                  result = false;
> >>     ++                      result = false;
> >>      +              }
> >
> > This reindentation looks odd.
>
> That's because the previous line has a comma.  So the reindent is
> right, not the code.

Whoops. :(

> Could you send a new patch with all these adjustments?  That would
> help a lot.

Will do!

Thanks,
--Jacob

Commits

  1. libpq: Add sslcertmode option to control client certificates

  2. Rewrite error message related to sslmode in libpq

  3. libpq: Add support for require_auth to control authorized auth methods

  4. Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connect.c