Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

Noboru Saito <noborusai@gmail.com>

From: Noboru Saito <noborusai@gmail.com>
To: Florents Tselai <florents.tselai@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-06-04T05:37:04Z
Lists: pgsql-hackers

Attachments

Hi,

Thank you very much for your feedback.

From my own testing, I believe that setting the indentation to zero does not
introduce any issues in the generated PDFs. If I had to mention a possible
side effect, it might be that admonition blocks become a bit more visually
prominent on the right side of the page.

To address this, I thought it could be helpful to add left and right margins
to nongraphical.admonition.properties so that admonitions are more centered.
I am attaching two files for your reference:

- A patch that adds margins to admonition blocks.
- An updated image where I have highlighted the space with a red
border for clarity.

The image shows:
- The original layout (top left)
- Only indentation set to 0 (top right)
- Indentation 0 plus admonition margins (bottom right)

Please let me know if you have any thoughts or further suggestions.

Best regards,
Noboru Saito

2025年6月1日(日) 18:27 Florents Tselai <florents.tselai@gmail.com>:
>
>
>
> > On 30 May 2025, at 8:27 AM, Noboru Saito <noborusai@gmail.com> wrote:
> >
> > Thank you Kuroda-san.
> >
> >> To confirm, generated pdf with current setting is left slide, and it would
> >> become like right side, is it correct? I prefer right one.
> >
> > Sorry for the lack of explanation.
> > That's right, the version on the left is the previous version,
> > and the version on the right has the patch applied.
>
> Thanks for starting this thread; the documentation could use some love.
>
> The patch applies cleanly for me and I can reproduce the screenshot shared above.
> Indeed I prefer the new margins too; the existing layout wastes too much whitespace indeed.
>

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Adjust some table column widths in PDF

  2. Improve PDF documentation margins