Horton

Re: [HACKERS] Bug in to_timestamp().

Amul Sul <sulamul@gmail.com>

View thread View on postgr.es
From: amul sul <sulamul@gmail.com>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: prabhat.sahu@enterprisedb.com, "David G. Johnston" <david.g.johnston@gmail.com>, Artur Zakirov <a.zakirov@postgrespro.ru>, Tom Lane <tgl@sss.pgh.pa.us>, Dmitry Dolgov <9erthalion6@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@enterprisedb.com>, Pavel Stehule <pavel.stehule@gmail.com>, Alex Ignatov <a.ignatov@postgrespro.ru>, Bruce Momjian <bruce@momjian.us>, amul sul <sul_amul@yahoo.co.in>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-09-19T10:38:00Z
Lists: pgsql-hackers 
On Wed, Sep 19, 2018 at 3:51 PM amul sul <sulamul@gmail.com> wrote:
>
> On Wed, Sep 19, 2018 at 2:57 PM Alexander Korotkov
[...]
>
> With this patch, to_date and to_timestamp behaving differently, see this:
>
> edb=# SELECT to_date('18 12 2011', 'xDDxMMxYYYY');
>       to_date
> --------------------
>  18-DEC-11 00:00:00
> (1 row)
>
> edb=# SELECT to_timestamp('18 12 2011', 'xDDxMMxYYYY');
>        to_timestamp
> ---------------------------
>  08-DEC-11 00:00:00 -05:00      <=========== Incorrect output.
> (1 row)
>
Sorry, this was wrong info -- with this patch, I had some mine trial changes.

Both to_date and to_timestamp behaving same with your patch -- the
wrong output, we are expecting that?

postgres =# SELECT to_date('18 12 2011', 'xDDxMMxYYYY');
  to_date
------------
 2011-12-08
(1 row)

postgres =# SELECT to_timestamp('18 12 2011', 'xDDxMMxYYYY');
      to_timestamp
------------------------
 2011-12-08 00:00:00-05
(1 row)

Regards,
Amul

Commits

  1. Improve behavior of to_timestamp()/to_date() functions

  2. Implement TZH and TZM timestamp format patterns

  3. as attache of this mail is patch (to the main tree) with to_char's