Re: Exclude pg_largeobject form pg_dump

Amul Sul <sulamul@gmail.com>

From: amul sul <sulamul@gmail.com>
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Andreas Joseph Krogh <andreas@visena.com>, PostgreSQL General <pgsql-general@postgresql.org>
Date: 2016-11-04T06:52:15Z
Lists: pgsql-hackers, pgsql-general
Hi Guillaume,

I found following issues with this patch, sorry missed in previous post:

#1 :
 43 @@ -392,6 +393,10 @@ main(int argc, char **argv)
 44                 dopt.outputBlobs = true;
 45                 break;
 46
 47 +           case 'B':           /* Don't dump blobs */
 48 +               dopt.include_everything = false;
 49 +               break;
 50 +

Touching dopt.include_everything flag does not seems to be a good idea
for '--no-blobs' option, our intension is to exclude blob only, but
this excluds other dump too (e.g COMMENT ON DATABASE, CREATE
EXTENSION, COMMENT ON EXTENSION, .., etc)  that what we don't want,
right?

#2 :
We should add note for default behaviour if --no-blobs & --blobs both
are specified.

Regards,
Amul Sul


Commits

  1. Add --no-blobs option to pg_dump