Horton

Re: [Patch] ALTER SYSTEM READ ONLY

Amul Sul <sulamul@gmail.com>

View thread View on postgr.es
From: Amul Sul <sulamul@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>, Rushabh Lathia <rushabh.lathia@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Prabhat Sahu <prabhat.sahu@enterprisedb.com>
Date: 2021-11-08T13:20:01Z
Lists: pgsql-hackers

Attachments

On Tue, Oct 26, 2021 at 4:29 PM Amul Sul <sulamul@gmail.com> wrote:
>
> On Mon, Oct 25, 2021 at 8:15 PM Robert Haas <robertmhaas@gmail.com> wrote:
> >
> > On Mon, Oct 25, 2021 at 3:05 AM Amul Sul <sulamul@gmail.com> wrote:
> > > Ok, did the same in the attached 0001 patch.
> > >
> > > There is no harm in calling LocalSetXLogInsertAllowed() calling
> > > multiple times, but the problem I can see is that with this patch user
> > > is allowed to call LocalSetXLogInsertAllowed() at the time it is
> > > supposed not to be called e.g. when LocalXLogInsertAllowed = 0;
> > > WAL writes are explicitly disabled.
> >
> > I've pushed 0001 and 0002 but I reversed the order of them and made a
> > few other edits.
> >
>
> Thank you!
>
> I have rebased the remaining patches on top of the latest master head
> (commit # e63ce9e8d6a).
>
> In addition to that, I did the additional changes to 0002 where I
> haven't included the change that tries to remove arguments of
> CleanupAfterArchiveRecovery() in the previous version. Because if we
> want to use XLogCtl->replayEndTLI and XLogCtl->replayEndRecPtr to
> replace EndOfLogTLI and EndOfLog arguments respectively, then we also
> need to consider the case where EndOfLog is changing if the
> abort-record does exist. That can be decided only in XLogAcceptWrite()
> before the shared memory value related to abort-record is going to be
> clear.
>

Attached is the rebased version of refactoring as well as the
pg_prohibit_wal feature patches for the latest master head (commit #
39a3105678a).

I was planning to attach the rebased version of isolation test patches
that Mark has posted before[1], but some permutation tests are not
stable, where expected errors get printed differently; therefore, I
dropped that from the attachment, for now.

Regards,
Amul

1] https://postgr.es/m/9BA3BA57-6B7B-45CB-B8D9-6B5EB0104FFA@enterprisedb.com

Commits

  1. Initialize variable to placate compiler.

  2. StartupXLOG: Don't repeatedly disable/enable local xlog insertion.

  3. StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportParameters.

  4. Postpone some end-of-recovery operations related to allowing WAL.

  5. Refactor some end-of-recovery code out of StartupXLOG().

  6. Re-enable contrib/bloom's TAP tests.

  7. Remove unnecessary call to ReadCheckpointRecord().

  8. Allow for error or refusal while absorbing a ProcSignalBarrier.

  9. Add comment to explain an unused function parameter

  10. Extend the ProcSignal mechanism to support barriers.

  11. At promotion, don't leave behind a partial segment on the old timeline.