Re: [Patch] ALTER SYSTEM READ ONLY

Amul Sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: Ibrar Ahmed <ibrar.ahmad@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-03-15T07:25:42Z

Lists: pgsql-hackers

Attachments

v20-0001-Implement-wal-prohibit-state-using-global-barrie.patch (application/x-patch) patch v20-0001
v20-0003-WIP-Documentation.patch (application/x-patch) patch v20-0003
v20-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch (application/x-patch) patch v20-0002

On Sun, Mar 14, 2021 at 11:51 PM Ibrar Ahmed <ibrar.ahmad@gmail.com> wrote:
>
> On Tue, Mar 9, 2021 at 3:31 PM Amul Sul <sulamul@gmail.com> wrote:
>>
>> On Thu, Mar 4, 2021 at 11:02 PM Amul Sul <sulamul@gmail.com> wrote:
>> >
>> > On Wed, Mar 3, 2021 at 8:56 PM Robert Haas <robertmhaas@gmail.com> wrote:
>> > >
>> > > On Tue, Mar 2, 2021 at 7:22 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>[....]
>
> One of the patch (v18-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch) from the latest patchset does not apply successfully.
>
> http://cfbot.cputube.org/patch_32_2602.log
>
> === applying patch ./v18-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch
>
> Hunk #15 succeeded at 2604 (offset -13 lines).
> 1 out of 15 hunks FAILED -- saving rejects to file src/backend/access/nbtree/nbtpage.c.rej
> patching file src/backend/access/spgist/spgdoinsert.c
>
> It is a very minor change, so I rebased the patch. Please take a look, if that works for you.
>

Thanks, I am getting one more failure for the vacuumlazy.c. on the
latest master head(d75288fb27b), I fixed that in attached version.

Regards,
Amul

Commits

Initialize variable to placate compiler.
- a030a0c5ccb1 15.0 landed
StartupXLOG: Don't repeatedly disable/enable local xlog insertion.
- 18e0913a4203 15.0 landed
StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportParameters.
- a75dbf7f9ee6 15.0 landed
Postpone some end-of-recovery operations related to allowing WAL.
- 811051c2e7af 15.0 landed
Refactor some end-of-recovery code out of StartupXLOG().
- 6df1543abfed 15.0 landed
Re-enable contrib/bloom's TAP tests.
- 7d1aa6bf1c27 15.0 cited
Remove unnecessary call to ReadCheckpointRecord().
- 1d919de5eb3f 15.0 cited
Allow for error or refusal while absorbing a ProcSignalBarrier.
- a3ed4d1efe9f 14.0 landed
Add comment to explain an unused function parameter
- 101f903e51f5 14.0 cited
Extend the ProcSignal mechanism to support barriers.
- 16a4e4aecd47 13.0 cited
At promotion, don't leave behind a partial segment on the old timeline.
- 7cbee7c0a1db 9.5.0 cited