Horton

Re: pg_verifybackup: TAR format backup verification

Amul Sul <sulamul@gmail.com>

View thread View on postgr.es
From: Amul Sul <sulamul@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Sravan Kumar <sravanvcybage@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-09-27T06:06:25Z
Lists: pgsql-hackers 
On Thu, Sep 26, 2024 at 12:18 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Thu, Sep 12, 2024 at 7:05 AM Amul Sul <sulamul@gmail.com> wrote:
> > The updated version attached. Thank you for the review !
>
> I have spent a bunch of time on this and have made numerous revisions.
> I hope to commit the result, aftering seeing what you and the
> buildfarm think (and anyone else who wishes to offer an opinion).
> Changes:
>

Thank you, Robert. The code changes look much better now.

A few minor comments:

+            each tablespace, named after the tablespace's OID. If the backup
+            is compressed, the relevant compression extension is added to the
+            end of each file name.

I am a bit unsure about the last line, especially the use of the word
"added."  I feel like it's implying that we're adding something, which
isn't true.
--

Typo: futher

--

The addition of simple_ptr_list_destroy will be part of a separate
commit, correct?

Regards,
Amul

Commits

  1. Adjust json_manifest_per_file_callback API in one more place.

  2. File size in a backup manifest should use uint64, not size_t.

  3. Fix some pg_verifybackup issues reported by Coverity.

  4. pg_verifybackup: Move some declarations to new pg_verifybackup.h

  5. pg_verifybackup: Move skip_checksums into verifier_context.

  6. Improve file header comments for astramer code.

  7. Move astreamer (except astreamer_inject) to fe_utils.

  8. Move recovery injector astreamer to a separate header file.

  9. Rename bbstreamer to astreamer.