Horton

Thread

Commits

  1. Remove global variable "LastRec" in xlog.c

  1. Unnecessary global variable declared in xlog.c

    Amul Sul <sulamul@gmail.com> — 2021-11-16T05:47:27Z

    Hi,

The attached patch moves the "LastRec" variable declaration inside
StartupXLOG() where it is supposed to be.

-- 
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

  2. Re: Unnecessary global variable declared in xlog.c

    Michael Paquier <michael@paquier.xyz> — 2021-11-16T06:12:38Z

    On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote:
> The attached patch moves the "LastRec" variable declaration inside
> StartupXLOG() where it is supposed to be.

Yes, reading through the code, your suggestion makes sense.  I'll
double-check and apply if there are no objections.
--
Michael

  3. Re: Unnecessary global variable declared in xlog.c

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-11-16T07:08:54Z

    Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote:
>> The attached patch moves the "LastRec" variable declaration inside
>> StartupXLOG() where it is supposed to be.

> Yes, reading through the code, your suggestion makes sense.  I'll
> double-check and apply if there are no objections.

I think LastRec was originally referenced by multiple functions
in xlog.c.  But it does look like it could be a local now.

			regards, tom lane

  4. Re: Unnecessary global variable declared in xlog.c

    Michael Paquier <michael@paquier.xyz> — 2021-11-17T02:06:04Z

    On Tue, Nov 16, 2021 at 02:08:54AM -0500, Tom Lane wrote:
> I think LastRec was originally referenced by multiple functions
> in xlog.c.  But it does look like it could be a local now.

Thanks for double-checking, applied this one as of f975fc3.
--
Michael

  5. Re: Unnecessary global variable declared in xlog.c

    Amul Sul <sulamul@gmail.com> — 2021-11-17T03:48:35Z

    On Wed, Nov 17, 2021 at 7:36 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Nov 16, 2021 at 02:08:54AM -0500, Tom Lane wrote:
> > I think LastRec was originally referenced by multiple functions
> > in xlog.c.  But it does look like it could be a local now.
>
> Thanks for double-checking, applied this one as of f975fc3.

Thank you, Michael.

Regards,
Amul